On Mon, Sep 07, 2009 at 08:07:33AM +0100, Trevor Daniels wrote: > > Graham Percival wrote Monday, September 07, 2009 12:53 AM > >> No; dump it in the Advanced git section. It's not something we >> want to insist that first-time contributors do. Once they show >> themselves to be regular, and get more excited about seeing their >> work being added to the official docs, *then* we'll ask them to do >> this. Get them hooked first. > > Are you sure? I can't see anything that tells first-time > contributors how to mail a patch. I've had trouble with > every one so far - it seems they all use Thunderbird. In > fact I'm surprised that bouncing their first few attempts > because they don't apply hasn't put off more of them.
Yes, I'm sure that I want the reviewer (i.e. you) to silently fix any end-of-line stuff, for the first 3-4 commits from somebody. Don't ask them to fix it, don't ask them to look in CG x.y, don't even tell them that there's anything questionable about their patches. (unless there's issues with the actual content) Let them attach patches on whatever system they have with whatever email program they use. If we can fix such broken patches by simply running "dos2unix foo.patch", then just do that. The above should probably be added to the CG section on applying patches. After 3-4 patches, point them at the relevant advanced git CG chapter that discusses different attachment options or git send-email or whatever. Taking it on an individual basis, of course -- if somebody seems technically challenged, then maybe don't bug them until 5 or 10 patches. If they seem quick, then maybe after only 2 patches. Cheers, - Graham _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
