Le lundi 18 janvier 2010 à 16:13 -0800, Mark Polesky a écrit : > Here's a small patch to clean up the `make help' output. I > know, it may soon be obsolete, but it was bothering me, and > it may yet help people who start compiling in the meantime. > I mentioned this idea a little while ago, but hadn't done > anything till now: > http://lists.gnu.org/archive/html/lilypond-devel/2009-12/msg00519.html > > Also, I removed the "-e" on the lines that have: > @echo -e "foo... > > because the "-e" is printed in the terminal output, like: > -e foo > > This made me think the "-e" doesn't do what someone thought > it would do. But I don't know. Was it okay to remove them?
As for any portability issue, you can't simply remove the "-e" just because it works better for you. Least you should do by submitting such a patch is telling us your OS and shell name and version; in order to be sure whether to apply this patch or not is to investigate which shell flavours and versions support or not -e flag, and in which cases -e is needed, by reading their respective documentations. FWIW it is supported and needed on my system (Fedora 12, bash-4.0.35, coreutils-7.6-8 which provides /bin/echo). That said, the simplest way to fix this portability issue is putting "@echo" at the beginning of each line. Best, John
signature.asc
Description: Ceci est une partie de message numériquement signée
_______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
