On 31 March 2010 21:43, Richard Gay <richard....@t-online.de> wrote:
> Thanks for this hint. Did as you suggested and extended
> get_current_note_head(). Now the not-so-spurious warnings do no
> longer occur and syllables are aligned correctly (at least for
> my simple test cases like the one I added to the docs). The attached
> patch again applies to current git.
Great!
Here are a few more comments on your patch:
+...@code{\lyricsto} keine Silben zugeordnet. Dieses Verhalten kann
Two spaces following a full stop.
+ \grace { f'16 [a'16] } c''2
+ \afterGrace c''2 { f'16 [a'16] }
f'16[
/* read */
"extendersOverRests ",
+ "includeGraceNotes "
comma follows "includeGraceNotes "
+Grob *get_current_note_head (Context *voice, bool includeGraceNotes);
bool include_grace_notes
+ if (((end_mom->main_part_ > now.main_part_) ||
+ (includeGraceNotes && (bool)now.grace_part_
+ && end_mom->main_part_ == now.main_part_
+ && end_mom->grace_part_ > now.grace_part_))
I think
(includeGraceNotes &&
end_mom->grace_part_ > now.grace_part_)
would be OK here
+ to_boolean (get_property ("includeGraceNotes")));
fix indent
>
> Since I am pretty new to lilypond, I can hardly figure out what might
> be good test cases for the patch. Also, I do not know how to test the
> changes to the Extender_engraver. Any hints, particularly regarding the
> latter?
I think something similar to your docs example would be fine as a test case.
I'd add a separate test for extenders; perhaps something like the
following snippet:
\version "2.13.18"
\relative c' {
c2 \grace { c16([ d e f] } g2)
}
\addlyrics {
\set includeGraceNotes = ##t
_ Ah __
}
Regards,
Neil
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
