I only had time to examine changing-defaults. I'll review the other files tonight.
http://codereview.appspot.com/1242044/diff/30002/34001 File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/1242044/diff/30002/34001#newcode357 Documentation/notation/changing-defaults.itely:357: music = \relative c'' { c4 c2. } We need a [verbatim] here. http://codereview.appspot.com/1242044/diff/30002/34001#newcode763 Documentation/notation/changing-defaults.itely:763: @c either make this verbatim, or add the finished example later? I don't follow / haven't taken the energy to follow it, but for now just make it [verbatim]. This patch is way too hard to understand as it is; postpone any intelligent rewriting until later. http://codereview.appspot.com/1242044/diff/30002/34001#newcode942 Documentation/notation/changing-defaults.itely:942: { d8 f d f d f d f | } I had difficulty following the voicing here. Could you expand the { \ossia } { d8 f d } bit? http://codereview.appspot.com/1242044/diff/30002/34001#newcode1019 Documentation/notation/changing-defaults.itely:1019: f4 Could these be 2 to make it a full bar? http://codereview.appspot.com/1242044/diff/30002/34001#newcode1243 Documentation/notation/changing-defaults.itely:1243: f4 make them 2s please. http://codereview.appspot.com/1242044/diff/30002/34001#newcode1287 Documentation/notation/changing-defaults.itely:1287: f4 again http://codereview.appspot.com/1242044/diff/30002/34001#newcode1518 Documentation/notation/changing-defaults.itely:1518: c8 c c c c c c c Erm... ok. Personally, I find it easier to understand when there's a repeated 8 in the half-bar position; it's much easier to see that you have two groups of 4: c8 c c c c8 c c c instead of one group of eight: c8 c c c c c c c But that's something we can discuss in GLISS, and change it back later on. I'm not objecting to this change now. http://codereview.appspot.com/1242044/diff/30002/34001#newcode2629 Documentation/notation/changing-defaults.itely:2629: a1 | a1 | Erm... ok. The barline checks are pretty silly here, and I hope that we'll disallow them in the GLISS style discussion and then change this example back. But I'll accept this patch making this change since the patch is so long and complicated. http://codereview.appspot.com/1242044/diff/30002/34001#newcode3499 Documentation/notation/changing-defaults.itely:3499: \\ This raises an interesting question about proper placement of \\, but it's not the right time to discuss this. So again, I'm ok with this change, with the understanding that we might be undoing it in a few months, after GLISS. http://codereview.appspot.com/1242044/show _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
