On 8/15/10 6:48 AM, "David Kastrup" <[email protected]> wrote: > > > Hi, I'm just trying to improve the documentation of > define-markup-command and define-markup-command-list. Those commands > have some functionality for defining aliases to existing commands. For > one thing, I have my doubts that this works properly, for another, it > complicates implementation and documentation (it was never documented in > lilypond-extending, anyhow). > > So I am leaning towards throwing it all out as I've checked that "make > test-clean && make test" is not affected. > > I'm making sure that throwing this stuff out is a separate commit from > improving the documentation, so it can easily be reverted iff somebody > considers it desirable. > > What is the general stance towards cleanup (of unused dormant stuff > never documented for general use) like that as long as it is contained > in separate commits and not intermingled with other changes?
IMO, getting rid of bit-rotted code is always a good idea. > Should it > be wrapped in a full review process? I think so. The full review process for removing old stuff is generally very short and sweet (post the patch, somebody important says OK), so I don't think it hurts a bit to do it. Thanks, Carl _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
