Looks good to me. Could you send me the patch (privately) so I can push it correctly attributed to you?
David: yes, I've already complained about Rietveld's atrocious lack of the real patch file. Cheers, - Graham On Mon, Aug 16, 2010 at 2:48 PM, <[email protected]> wrote: > Reviewers: Graham Percival, > > > http://codereview.appspot.com/2004041/diff/1/2 > File Documentation/notation/input.itely (right): > > http://codereview.appspot.com/2004041/diff/1/2#newcode110 > Documentation/notation/input.itely:110: @file{fandangoforelephants.pdf} > (or @file{fandangoforelephants.png}, > On 2010/08/16 09:31:24, Graham Percival wrote: >> >> or .eps, or .ps, or .svg... just mention .pdf. Anybody doing weird > > stuff will >> >> know what you mean. > > Done. > > http://codereview.appspot.com/2004041/diff/1/2#newcode114 > Documentation/notation/input.itely:114: must explicitly code a > @code{\book} block. > On 2010/08/16 09:31:24, Graham Percival wrote: >> >> what? Am I missing something here? This sounds completely wrong. > >> LATER EDIT: err, ok, the comment about lilypond-book was related to > > producing >> >> multiple scores in one book. But that only refers to that particular > > context; >> >> you can use lilypond-book without writing any explicit \book blocks. > > I do that >> >> all the time. > >> Please revert this change. > > Paragraph removed. > > http://codereview.appspot.com/2004041/diff/1/2#newcode422 > Documentation/notation/input.itely:422: This behaviour can be changed by > setting the variable > On 2010/08/16 09:31:24, Graham Percival wrote: >> >> Sorry, the doc policy explicitly calls for American spelling. Please > > revert >> >> this change. > > Under protest. > The doc policy sucks. > Webster was a dyslexic (ask any non-American chemist about element Al). > > Description: > T1041 - Add descriptions for \bookOutputSuffix and \bookOutputName to > documents (NR). > > Please review this at http://codereview.appspot.com/2004041/show > > Affected files: > M Documentation/notation/input.itely > > > > _______________________________________________ > lilypond-devel mailing list > [email protected] > http://lists.gnu.org/mailman/listinfo/lilypond-devel > _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
