Hi Valentin, I think this a great improvement on the last patch. Once you've sorted out the nitpicks, it should be good to go.
Cheers, Neil http://codereview.appspot.com/2699041/diff/9001/input/regression/note-names.ly File input/regression/note-names.ly (right): http://codereview.appspot.com/2699041/diff/9001/input/regression/note-names.ly#newcode15 input/regression/note-names.ly:15: g bf d c g4 http://codereview.appspot.com/2699041/diff/9001/input/regression/note-names.ly#newcode20 input/regression/note-names.ly:20: (set! pitchnames dutchPitchnames) Heh, you still haven't tested this, have you? http://codereview.appspot.com/2699041/diff/9001/input/regression/note-names.ly#newcode22 input/regression/note-names.ly:22: bes a g fis bes4 http://codereview.appspot.com/2699041/diff/9001/input/regression/note-names.ly#newcode26 input/regression/note-names.ly:26: sol fa mib re sol4 http://codereview.appspot.com/2699041/diff/9001/ly/catalan.ly File ly/catalan.ly (right): http://codereview.appspot.com/2699041/diff/9001/ly/catalan.ly#newcode6 ly/catalan.ly:6: \language "catalan" add a newline (ditto all other language files) http://codereview.appspot.com/2699041/diff/9001/ly/language-init.ly File ly/language-init.ly (right): http://codereview.appspot.com/2699041/diff/9001/ly/language-init.ly#newcode22 ly/language-init.ly:22: #(define language-pitch-names `( needs indenting correctly (I suggest moving `( to the next line, otherwise the correct indentation will be too far to the right) http://codereview.appspot.com/2699041/diff/9001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): http://codereview.appspot.com/2699041/diff/9001/ly/music-functions-init.ly#newcode368 ly/music-functions-init.ly:368: (if (not (null? language-def)) I prefer (if (pair? language-def) http://codereview.appspot.com/2699041/diff/9001/ly/music-functions-init.ly#newcode374 ly/music-functions-init.ly:374: (ly:warning (_ "Could not find language ~a. Ignoring.") str)) remove extra space before `str' http://codereview.appspot.com/2699041/ _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
