On 2010/10/31 22:24:17, Neil Puttock wrote:
http://codereview.appspot.com/2723043/diff/7001/lily/tab-tie-follow-engraver.cc#newcode69
lily/tab-tie-follow-engraver.cc:69: if (info.grob ()->name () ==
"Glissando")
If you needed to distinguish glissandos from other lines, it would be
more
idiomatic to add an interface (glissando-interface), then use
info.grob->internal_has_interface (ly_symbol2scm
("glissando-interface"))
This is going away, so it won't apply to this patch (because we don't
need to acknowledge glissandos). But if we did, and we added a
glissando-interface, then instead of
Tab_tie_follow_engraver::acknowledge_line_spanner wouldn't we just use
Tab_tie_follow_engraver::acknowledge_glissando?
But it would seem strange to me to add an interface with no properties
that can be set,
which is what I think I'd be doing if I added a glissando_interface.
Any comment on this thought?
Thanks,
Carl
http://codereview.appspot.com/2723043/
_______________________________________________
lilypond-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/lilypond-devel
