Am 24.11.2010 00:41, schrieb Neil Puttock:
On 23 November 2010 23:30, Carl Sorensen<[email protected]> wrote:
Pushed, thanks.
That was quick, thanks!
I'm sorry I'm a bit late, but this
+(define-markup-command (customFretLabel
+ layout props fret-label) (string?)
seems unncessary; it's just an inferior version of vcenter. There's
nothing about it which applies specifically to frets.
Sorry - in my first version, I had some font-specific arguments in this
definition, but then decided that this markup should simply use the defaults
used for the fret numbers, so I removed the font stuff.
I attached a patch to remove the unnecessary markup definition.
Regards,
Marc
Cheers,
Neil
From 87fc9dbd0217658c85fa120c8e2aa0afcf3b492a Mon Sep 17 00:00:00 2001
From: Marc Hohl <[email protected]>
Date: Wed, 24 Nov 2010 08:37:07 +0100
Subject: [PATCH] Tablature: simplify custom fret label callback
---
scm/tablature.scm | 12 ++----------
1 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/scm/tablature.scm b/scm/tablature.scm
index 1aa766d..7845f21 100644
--- a/scm/tablature.scm
+++ b/scm/tablature.scm
@@ -256,15 +256,7 @@
(staff-space (ly:staff-symbol-staff-space grob)))
(/ width staff-space)))
-;; define custom fret label as markup
-(define-markup-command (customFretLabel
- layout props fret-label) (string?)
- #:category music
- "Draw a custom tab fret label."
-
- (interpret-markup layout props
- (markup #:vcenter fret-label)))
-;; use it for custom fret labels
+;; a callback for custom fret labels
(define-public ((tab-note-head::print-custom-fret-label fret) grob)
- (grob-interpret-markup grob (make-customFretLabel-markup fret)))
+ (grob-interpret-markup grob (markup #:vcenter fret)))
--
1.7.0.4
_______________________________________________
lilypond-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/lilypond-devel
