Thanks for the review, Neil. I've responded to all your comments.
I've also defined a new print function for TabNoteHeads in Scheme. It will take care of all of the necessary parentheses and harmonic brackets, based on the settings of 'display-cautionary and 'style. Thanks, Carl http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc File lily/tab-tie-follow-engraver.cc (right): http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode52 lily/tab-tie-follow-engraver.cc:52: void process_acknowledged (); On 2010/11/16 23:30:42, Neil Puttock wrote:
remove
Done. http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode64 lily/tab-tie-follow-engraver.cc:64: ties_.push_back (dynamic_cast <Spanner *> (info.grob ())); On 2010/11/16 23:30:42, Neil Puttock wrote:
push_back (info.spanner ())
Done. http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode70 lily/tab-tie-follow-engraver.cc:70: glissandi_.push_back (dynamic_cast <Spanner *> (info.grob ())); On 2010/11/16 23:30:42, Neil Puttock wrote:
push_back (info.spanner ())
Done. Thanks for teaching me about these calls. http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode76 lily/tab-tie-follow-engraver.cc:76: note_heads_.push_back (dynamic_cast<Item *> (info.grob ())); On 2010/11/16 23:30:42, Neil Puttock wrote:
push_back (info.item ())
Done. http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode82 lily/tab-tie-follow-engraver.cc:82: slurs_.push_back (dynamic_cast<Spanner *> (info.grob ())); On 2010/11/16 23:30:42, Neil Puttock wrote:
push_back (info.spanner ())
Done. http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode86 lily/tab-tie-follow-engraver.cc:86: Tab_tie_follow_engraver::process_acknowledged () On 2010/11/16 23:30:42, Neil Puttock wrote:
remove
Done. http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode108 lily/tab-tie-follow-engraver.cc:108: Item *slur_cause = dynamic_cast<Item *> (unsmob_grob (left_cause)); On 2010/11/16 23:30:42, Neil Puttock wrote:
unsmob_item (left_cause)
Done. http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode121 lily/tab-tie-follow-engraver.cc:121: if ((left_bound == note_heads_[k])) On 2010/11/16 23:30:42, Neil Puttock wrote:
remove extra parentheses
Done. http://codereview.appspot.com/2723043/diff/70001/lily/tab-tie-follow-engraver.cc#newcode154 lily/tab-tie-follow-engraver.cc:154: On 2010/11/16 23:30:42, Neil Puttock wrote:
gratuitous newline
Done. http://codereview.appspot.com/2723043/diff/70001/scm/define-grob-interfaces.scm File scm/define-grob-interfaces.scm (right): http://codereview.appspot.com/2723043/diff/70001/scm/define-grob-interfaces.scm#newcode214 scm/define-grob-interfaces.scm:214: '(details display-cautionary)) On 2010/11/16 23:30:42, Neil Puttock wrote: New structure is span-start and display-cautionary. tie-follow is implied in the callback that is used. display-cautionary is used by glissando callback and in new tab-note-head::print function. http://codereview.appspot.com/2723043/diff/70001/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): http://codereview.appspot.com/2723043/diff/70001/scm/define-grob-properties.scm#newcode1016 scm/define-grob-properties.scm:1016: (span-start ,boolean? "Is the note at the start of a spanner?") On 2010/11/16 23:30:42, Neil Puttock wrote:
note head
Done. http://codereview.appspot.com/2723043/diff/70001/scm/define-grob-properties.scm#newcode1023 scm/define-grob-properties.scm:1023: (tie-follow ,boolean? "Is the note at the end of a tie?") On 2010/11/16 23:30:42, Neil Puttock wrote:
note head
Eliminated http://codereview.appspot.com/2723043/diff/70001/scm/define-grobs.scm File scm/define-grobs.scm (right): http://codereview.appspot.com/2723043/diff/70001/scm/define-grobs.scm#newcode822 scm/define-grobs.scm:822: line-interface On 2010/11/16 23:30:42, Neil Puttock wrote:
indent
I assume you mean to use tabs. Done. http://codereview.appspot.com/2723043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel