Lots of good discussion here, but I'm finding a bit confusing.  James,
could you extract whatever part(s) of your first patch that everybody
agreed on, and make a separate patch that only does those?  That way, we
can get the "obvious" stuff pushed, and then focus on whatever "not
obvious" stuff is left.  I'd also suggest that once the "obvious" stuff
is pushed, you create a patch for only 1 of the remaining files -- that
will let us focus even more.

Remember that patches should not only *be* good, they must be *seen* to
be good.  When there's a lot of unrelated stuff in the same patch, it's
harder to see that stuff is good.

http://codereview.appspot.com/3581041/

_______________________________________________
lilypond-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to