Thanks, James!

Carl



http://codereview.appspot.com/3705042/diff/1/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):

http://codereview.appspot.com/3705042/diff/1/Documentation/learning/fundamental.itely#newcode2114
Documentation/learning/fundamental.itely:2114: objects to note heads, if
you remove the @code{Note_heads_engraver}
I agree with Graham.  You either need to change the comma to a
semicolon, or add a conjunction like "so".  I think it would actually be
best to put in a period and make it two sentences.

I also think it would be better to reword it as

"If the @code{Note_heads_engraver} is removed"

http://codereview.appspot.com/3705042/diff/1/Documentation/notation/repeats.itely
File Documentation/notation/repeats.itely (right):

http://codereview.appspot.com/3705042/diff/1/Documentation/notation/repeats.itely#newcode151
Documentation/notation/repeats.itely:151: of the braces of the grouped
notes within an @co...@bs{}alternative} block, otherwise you will not
get the expected number of endings.  Any bar checks used inside
@co...@bs{}alternative} block must be placed in inside the braces of
each group of notes.}
I think that with the addition of the bar checks to the examples, this
warning can be eliminated.

The only reason it was needed was because the example we had previously
had no bar checks, so a user guessed on where to put them and guessed
wrong.

http://codereview.appspot.com/3705042/

_______________________________________________
lilypond-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to