Thanks for the review, Patrick.
I've made the changes and posted a new patch set.
http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely#newcode1111
Documentation/notation/rhythms.itely:1111: c8^\markup "Beamed (2 2)"
\repeat unfold 7 { c8 } |
On 2010/12/20 01:20:30, pkx166h wrote:
c8^ \markup { "Beamed (2 2)" } as per CG also I'd personally put the
\repeat on
a new line.
Done.
http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely#newcode1119
Documentation/notation/rhythms.itely:1119: c8^\markup "Beamed (3 1)"
\repeat unfold 7 { c8 } |
On 2010/12/20 01:20:30, pkx166h wrote:
Same as above.
Done.
http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely#newcode1172
Documentation/notation/rhythms.itely:1172: #'()
% beamExceptions
On 2010/12/20 01:20:30, pkx166h wrote:
The spacing here with the comments after each #'() construct is
inconsistent
with the example above.
Actually, I think the spacing is consistent. They are farther to the
right because the indentation level is higher for those lines, due to
the addition of the StaffGroup and the Staff.
But I guess they don't need to be that far to the right. They were that
far to the right because they originally had an unnecessary
beamExceptions rule. I'll squeeze them all in. It will look better.
http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely#newcode1175
Documentation/notation/rhythms.itely:1175: }
On 2010/12/20 01:20:30, pkx166h wrote:
This brace needs one more space by the looks of it
Nice catch!
Done
http://codereview.appspot.com/3693042/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
