hi Joe, >> do you think my patch is a good start? > > Yes, but you need to be careful about what happens when bar-size is set. > Currently, your patch will break (for example) input/regression/drums.ly > because it ignores bar-size.
well, I admit I haven't run regtests, but I did now and (having found and fixed an unrelated error) I can see no unintended change (i.e. drums.ly works as before). actually I don't know what to expect with changed bar-size - I attached two more tests: spantest1 is a modification of my original spantest, and the result looks the same; spantest3 is a modification of spantest2, and it's consistent, perhaps even good. >> I removed the center setting code and that >> (with my patch still active) made my example perfect; >> however, the attached complementary test (with bar >> lines only within staff, not between them) failed, >> but it's perfect with current center setting >> (independently whether my original patch is active or not). > > Since Bar_line::compound_barline is used in both BarLine and SpanBar, you > will need to find some solution that works for both cases. It won't be as > simple as just enabling or disabling the centering code. oh, uh. thanks for this hint as well; I'll investigate. p
spantest1.ly
Description: Binary data
spantest3.ly
Description: Binary data
_______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
