Also works, also passes make check, also attached, also on Rietveld: http://codereview.appspot.com/4006044 From Neil's e-mail, it seems that he advocates this solution because "Clefs are taken into account (shown by the yellow-blue skyline pair) when calculating horizontal skylines for NonMusicalPaperColumn, whereas key signatures are completely ignored. We can ensure KeySignature is accounted for by adding it to `pure-print-callbacks'."
0001-Alternative-1472-fix.patch
Description: Binary data
Cheers, MS On Jan 19, 2011, at 7:22 PM, Carl Sorensen wrote: > > On 1/19/11 4:33 PM, "Mike Solomon" <[email protected]> wrote: > >> Got it. >> >> Then, here is the state of things: >> >> 1/6 >> Bug is first reported on the bug list. >> >> 1/7 >> Neil reports adding a default 'extra-spacing-height to key signature. >> >> 1/10 >> Keith confirms that this works and that he gets a clean make check. >> >> 1/13 >> Phil holmes reports the regression on the bugtracker (2.13.46). >> Graham identifies that the output was correct on the bugtracker (2.12.3). >> >> 1/19 >> Mike confirms that the regression is indeed due to 1190 and realizes that he >> is not subscribed to the bug list. >> Mike proposes a patch based on the discussion between Neil and Keith, which >> is >> attached to this e-mail and on Rietveld @ >> http://codereview.appspot.com/4031042. > > I think you missed Neil's email of 1/14, which suggested that the proper fix > for this issue was not to add 'extra-spacing-height to the KeySignature, but > to add KeySignature to the pure-print-callback list. > > Or maybe the patch should have both the 'extra-spacing-height and the > pure-print-callback. > > Thanks, > > Carl > >
_______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
