The reasonable score is to go in a subsequent patch. Stay tuned. On Mon, Jan 31, 2011 at 11:44 PM, <[email protected]> wrote: > LGTM. Reads a lot cleaner and is much more extensible. > > This may be for another patch, but I think one problem that remains with > the algorithm is that the "reasonable_score" parameter may inadvertently > exclude certain quants from receiving a demerit they deserve because > they are not part of a for loop. More qualified quants then get hit > with a demerit and become less reasonable than the previously > "unreasonable" quant. I know that taking away the "if" statement that > checks for reasonability would increase computation time, but is there a > better way to assure that non-reasonable scores will not rise to the top > of the pile because they have been excluded from stages of the > penalizing process? > > http://codereview.appspot.com/4001046/ >
-- Han-Wen Nienhuys - [email protected] - http://www.xs4all.nl/~hanwen _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
