http://codereview.appspot.com/3334043/diff/1/lily/part-combine-engraver.cc File lily/part-combine-engraver.cc (right):
http://codereview.appspot.com/3334043/diff/1/lily/part-combine-engraver.cc#newcode62 lily/part-combine-engraver.cc:62: if (ev->get_property ("class") == ly_symbol2scm ("clear-partcombine-event")) ev->in_event_class ("clear-partcombine-event") http://codereview.appspot.com/3334043/diff/1/lily/part-combine-engraver.cc#newcode65 lily/part-combine-engraver.cc:65: item_to_create_ = false; item_to_create_ currently reflects the existence of active_event_; will you be adding further code where they're set separately? http://codereview.appspot.com/3334043/diff/1/lily/part-combine-iterator.cc File lily/part-combine-iterator.cc (right): http://codereview.appspot.com/3334043/diff/1/lily/part-combine-iterator.cc#newcode308 lily/part-combine-iterator.cc:308: kill_mmrest (CONTEXT_ONE); This doesn't do anything, as far as I can tell; kill_mmrest () broadcasts a zero-length MultiMeasureRestEvent, which is ignored by the Multi_measure_rest_engraver. I think you can junk all the kill_mmrest () calls. http://codereview.appspot.com/3334043/diff/1/lily/part-combine-iterator.cc#newcode386 lily/part-combine-iterator.cc:386: for (int i = 0; i < NUM_OUTLETS-1; i++) NUM_OUTLETS - 1 http://codereview.appspot.com/3334043/diff/1/scm/define-music-types.scm File scm/define-music-types.scm (right): http://codereview.appspot.com/3334043/diff/1/scm/define-music-types.scm#newcode39 scm/define-music-types.scm:39: (part-combine-status . apart) How will you be using this property? It seems to be duplicating the name of the event. doc in define-music-properties.scm http://codereview.appspot.com/3334043/ _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
