http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf File mf/feta-braces.mf (right):
http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf#newcode151 mf/feta-braces.mf:151: fatten := 1 + fatten_factor - min ( number * fatten_factor / 256, fatten_factor); This is a bit obscure to me. How about fatten := min(number/256,1)[1+fatten_factor,1]; That makes it more obvious that the factor is running from 1+fatten_factor to 1. There does not seem to be much point in using min, either, regarding clarity. So maybe the whole thing can be written as if number<256: x := x*(number/256[1+fatten_factor,1]); fi However, "fatten_factor" sounds like a _factor_, so it would make more sense to change it to 2.5 (is that really the intended value? Seems really large!) and write this as if number<256: x := (number/256)[x*fatten_factor,x]; fi I think that expresses the meaning better, even without requiring an extra variable "fatten". http://codereview.appspot.com/4518052/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
