looks basically good.
http://codereview.appspot.com/4515042/diff/1/make/website.make File make/website.make (right): http://codereview.appspot.com/4515042/diff/1/make/website.make#newcode8 make/website.make:8: quiet-run = $(findstring s, $(MAKEFLAGS)) I think I'd still rather have this be: quiet-run = TRUE or True or true or however you do this in make http://codereview.appspot.com/4515042/diff/1/make/website.make#newcode10 make/website.make:10: quiet-string=-q can this name be more descriptive? like quiet-option ? (I'm not overly fond of that suggestion; I'm just trying to spark your imagination) http://codereview.appspot.com/4515042/diff/1/scripts/build/bib2texi.py File scripts/build/bib2texi.py (right): http://codereview.appspot.com/4515042/diff/1/scripts/build/bib2texi.py#newcode16 scripts/build/bib2texi.py:16: suppress_output = '' could this be a boolean instead? http://codereview.appspot.com/4515042/diff/1/scripts/build/bib2texi.py#newcode27 scripts/build/bib2texi.py:27: suppress_output = ' -terse ' set the boolean here http://codereview.appspot.com/4515042/diff/1/scripts/build/bib2texi.py#newcode63 scripts/build/bib2texi.py:63: cmd = "TEXMFOUTPUT=%s bibtex %s %s" % (tmpdir, suppress_output, tmpfile) maybe make an extra var here: suppress_output_command = '' if suppress_output: suppress_output_command = ' -terse ' http://codereview.appspot.com/4515042/diff/1/scripts/build/bib2texi.py#newcode65 scripts/build/bib2texi.py:65: if (suppress_output != ' -terse '): if suppress_output: the reason for all this is that I don't like seeing stuff like the line above; it feels "fragile" to me. Not that I ever expect the command-line option of bibtex to change, but still... http://codereview.appspot.com/4515042/diff/1/scripts/build/mass-link.py File scripts/build/mass-link.py (right): http://codereview.appspot.com/4515042/diff/1/scripts/build/mass-link.py#newcode16 scripts/build/mass-link.py:16: # PH note - I've just commented this out, since it's so not-helpful I suggest removing it entirely. http://codereview.appspot.com/4515042/diff/1/scripts/build/website-known-missing-files.txt File scripts/build/website-known-missing-files.txt (right): http://codereview.appspot.com/4515042/diff/1/scripts/build/website-known-missing-files.txt#newcode1 scripts/build/website-known-missing-files.txt:1: ancient-notation.itely What's this file? Didn't we already have this file in the previous commit? http://codereview.appspot.com/4515042/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
