LGTM apart from some editorial nitpicks noted. Trevor
http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely#newcode775 Documentation/notation/simultaneous.itely:775: @code{Voice} is printed. Stem directions set up & down accordingly while Stem directions are set automatically while Solo and @notation{a due} parts are identified and marked accordingly. http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely#newcode814 Documentation/notation/simultaneous.itely:814: Even though both parts have identical notes in the third measure, only Both parts have identical notes in the third measure, so only one ... http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely#newcode816 Documentation/notation/simultaneous.itely:816: are set automatically, depending whether there is a solo or unison. depending on whether the parts are playing solo or in unison. http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely#newcode824 Documentation/notation/simultaneous.itely:824: @code{Voice} contexts, so if using @code{\relative} octaves, then so if the music is being specified in relative mode ... http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely#newcode834 Documentation/notation/simultaneous.itely:834: A @code{\relative} section that is placed outside of @code{\partcombine} section that encloses @code{\partcombine} has no ... http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely#newcode854 Documentation/notation/simultaneous.itely:854: into a chord, or showing one voice as solo is, therefore, not ideal as space http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely#newcode864 Documentation/notation/simultaneous.itely:864: @code{\partcombineApart} or @code{\partcombineApartOnce}: This keeps the I think the items in this section read better if "and" is used together with plural verbs, like this: @code{\partcombineApart} and @code{\partcombineApartOnce} keep the notes ... Similarly for the other items (not marked). http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely#newcode956 Documentation/notation/simultaneous.itely:956: started when combining notes that have just started in the other space http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely#newcode957 Documentation/notation/simultaneous.itely:957: @code{Voice}. This can lead to a number of unexpected issues including space http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely#newcode966 Documentation/notation/simultaneous.itely:966: give the voices, internally, its own custom names; @code{one} and colon http://codereview.appspot.com/4629073/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
