LGTM.
http://codereview.appspot.com/4810042/diff/4001/input/regression/set-once.ly File input/regression/set-once.ly (right): http://codereview.appspot.com/4810042/diff/4001/input/regression/set-once.ly#newcode1 input/regression/set-once.ly:1: \version "2.15.5" 2.15.6 http://codereview.appspot.com/4810042/diff/4001/input/regression/set-once.ly#newcode5 input/regression/set-once.ly:5: texidoc = "@code{\once\set} should revert the setting after the next moment \once \set http://codereview.appspot.com/4810042/diff/4001/input/regression/set-once.ly#newcode6 input/regression/set-once.ly:6: to the previous value rather than the default." this sounds a bit ambiguous; could be misinterpreted http://codereview.appspot.com/4810042/diff/4001/input/regression/set-once.ly#newcode11 input/regression/set-once.ly:11: < e -1>1 | <e-1>1 etc. http://codereview.appspot.com/4810042/diff/4001/input/regression/set-once.ly#newcode14 input/regression/set-once.ly:14: < e -1> -"left" | you could add an assert function (using ApplyContext) to verify that the value returns to the original \set (if you're feeling paranoid :) http://codereview.appspot.com/4810042/diff/4001/lily/property-iterator.cc File lily/property-iterator.cc (right): http://codereview.appspot.com/4810042/diff/4001/lily/property-iterator.cc#newcode43 lily/property-iterator.cc:43: /* For \once\set install a finalization hook to reset the property to the old \once \set http://codereview.appspot.com/4810042/diff/4001/lily/property-iterator.cc#newcode44 lily/property-iterator.cc:44: * value after the next timestep */ don't you mean at the end of the current timestep? http://codereview.appspot.com/4810042/diff/4001/lily/property-iterator.cc#newcode74 lily/property-iterator.cc:74: // restore the value before the \once\set command \once \set http://codereview.appspot.com/4810042/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
