RE: Rewrite regtest mozart-hrn-3.ly (issue4811066)

James Lowe Mon, 08 Aug 2011 08:52:19 -0700

no problem. I'll do it now.

James


)-----Original Message-----
)From: Phil Holmes [mailto:[email protected]]
)Sent: 08 August 2011 16:46
)To: James Lowe; [email protected];
)[email protected]; [email protected]; lilypond-
)[email protected]; [email protected]
)Subject: Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)
)
)
)Woh.  There's an error - \url isn't part of Lilypond syntax!  I'd corrected 
this
)to GP, but here's a corrected patch.
)
)--
)Phil Holmes
)
)
)----- Original Message -----
)From: "James Lowe" <[email protected]>
)To: "Phil Holmes" <[email protected]>;
)<[email protected]>; <[email protected]>;
)<[email protected]>; <[email protected]>; <lilypond-
)[email protected]>; <[email protected]>
)Sent: Monday, August 08, 2011 4:13 PM
)Subject: RE: Rewrite regtest mozart-hrn-3.ly (issue4811066)
)
)
)I'll push it.
)
)james
)
))-----Original Message-----
))From: [email protected]
))[mailto:[email protected]]
)On )Behalf Of Phil Holmes
))Sent: 08 August 2011 15:54
))To: [email protected]; [email protected];
))[email protected]; [email protected]; [email protected];
))[email protected]; [email protected]
))Subject: Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)
))
))----- Original Message -----
))From: <[email protected]>
))To: <[email protected]>; <[email protected]>;
))<[email protected]>; <[email protected]>
))Cc: <[email protected]>; <[email protected]>
))Sent: Sunday, August 07, 2011 11:42 PM
))Subject: Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)
))
))
))> LGTM.  My comment is a tiny nitpick; I don't think it needs to hold up )>
)pushing this.
))>
))>
))>
))http://codereview.appspot.com/4811066/diff/8003/input/regression/m
)o
))zar
))> t-hrn-3.ly File input/regression/mozart-hrn-3.ly (right):
))>
))>
))http://codereview.appspot.com/4811066/diff/8003/input/regression/m
)o
))zar
))> t-hrn-3.ly#newcode27
))> input/regression/mozart-hrn-3.ly:27: \typewriter { )>
)"http://mutopiaproject.org/"; } this would be slightly nicer if you )> used
)\url instead of \typewriter.
))> That would use that typeface, but would also produce a clickable link.
))>
))> http://codereview.appspot.com/4811066/
))
))Nitpick changed - I've kept typewriter for the look, but added url.  Patch
))attached.  Please push.
))
))--
))Phil Holmes

_______________________________________________
lilypond-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/lilypond-devel

RE: Rewrite regtest mozart-hrn-3.ly (issue4811066)

Reply via email to