Response to Carl's comments, plus notes to self to sort out white-space issues.
New Patchset will follow Ian http://codereview.appspot.com/4849054/diff/1/scm/lily.scm File scm/lily.scm (right): http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode116 scm/lily.scm:116: "midi") Sort out (increase) indentation for lines 115-116 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode229 scm/lily.scm:229: (ly:message On 2011/08/11 00:01:29, Carl wrote:
Indent is wrong here -- should align with test, not with if.
Done. http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode272 scm/lily.scm:272: (ly:get-option 'trace-memory-frequency) On 2011/08/11 00:01:29, Carl wrote:
Indentation needs to move in one parenthesis level on this line and
next. Done. http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode296 scm/lily.scm:296: (ly:error (_ "cannot find: ~A") x)) On 2011/08/11 00:01:29, Carl wrote:
indent one more level
Done. http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode299 scm/lily.scm:299: (ly:progress "]\n")))) On 2011/08/11 00:01:29, Carl wrote:
indent one more level
Done. http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode303 scm/lily.scm:303: (vector-ref (uname) 0) char-set:letter+digit))) On 2011/08/11 00:01:29, Carl wrote:
needs to be indented beyond string-tokenize
Done. http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode305 scm/lily.scm:305: (member (string-downcase (cadr platform)) '("95" "98" "me"))))) On 2011/08/11 00:01:29, Carl wrote:
Indent one more level
Done. http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode312 scm/lily.scm:312: (string-regexp-substitute "\\\\" "/" x)))) Sort out (increase) indentation for lines 311-312 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode327 scm/lily.scm:327: (eq? (string-ref file-name 2) #\/)))))) Sort out (increase) indentation for lines 322-327 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode342 scm/lily.scm:342: (fresh-interface!)))) Sort out (increase) indentation for lines 336-340/342 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode359 scm/lily.scm:359: #t)) Sort out (increase) indentation for lines 352-359 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode364 scm/lily.scm:364: (recursion-helper (cdr signature) (cdr arguments) (1+ count))))) Sort out (increase) indentation for lines 362-364 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode395 scm/lily.scm:395: (ly:version)) Sort out (increase) indentation for lines 393-395 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode603 scm/lily.scm:603: (stats (gc-stats))) Increase indentation. http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode607 scm/lily.scm:607: (assoc-get 'total-cells-allocated stats 0)))) Increase indentation for 605-607 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode611 scm/lily.scm:611: (diff (map (lambda (y) (apply - y)) (zip this last)))) Increase indentation http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode618 scm/lily.scm:618: (cadr diff)))) Sort out (increase) indentation for lines 614-618 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode634 scm/lily.scm:634: (string<? (car x) (car y)))))) Sort out (increase) indentation for lines 631 634 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode645 scm/lily.scm:645: (outfile (open-file out-file-name "w"))) Sort out (increase) indentation for lines 639 645 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode655 scm/lily.scm:655: protects)) Sort out (increase) indentation for lines 649 655 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode661 scm/lily.scm:661: protects))) Sort out (increase) indentation for lines 657 661 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode704 scm/lily.scm:704: (mem (string->number (match:substring (car interesting) 1)))) Sort out (increase) indentation for lines 698 704 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode722 scm/lily.scm:722: acc)) Sort out (increase) indentation for lines 718 722 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode760 scm/lily.scm:760: files))))) Sort out (increase) indentation for lines 755 760 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode810 scm/lily.scm:810: (ly:exit 1 #f)))))) Sort out (increase) indentation for lines 764 810 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode823 scm/lily.scm:823: (ly:exit 0 #f))))) Sort out (increase) indentation for lines 816-818, 820-823 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode836 scm/lily.scm:836: (set! failed (append (list failed-file) failed))))) Sort out (increase) indentation for lines 828-836 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode864 scm/lily.scm:864: (dump-gc-protects) Sort out (increase) indentation for lines 841-864 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode872 scm/lily.scm:872: (dump-profile "lily-run-total" '(0 0) (profile-measurements))) Sort out (increase) indentation for lines 870/872 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode878 scm/lily.scm:878: (lambda (x . args) (handler x file-name)))) Sort out (increase) indentation for lines 887-888 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode891 scm/lily.scm:891: (ly:message "# -*-compilation-*-")) Sort out (increase) indentation for lines 887-891 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode901 scm/lily.scm:901: (ly:exit 0 #f))))) Sort out (increase) indentation for lines 893-901 http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode907 scm/lily.scm:907: (cmd (get-editor-command welcome-ly 0 0 0))) Sort out (increase) indentation for lines 905-907 http://codereview.appspot.com/4849054/diff/1/scm/markup.scm File scm/markup.scm (right): http://codereview.appspot.com/4849054/diff/1/scm/markup.scm#newcode74 scm/markup.scm:74: (xoff (+ space (cdr (ly:stencil-extent head X))))) On 2011/08/11 00:01:29, Carl wrote:
Please keep this interval-length, because it isolates the function
from the data
representation.
If we need to split lily-library.scm so we can load it earlier, we
should do so. Done. http://codereview.appspot.com/4849054/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
