LGTM. Only some minor style nitpicks; you may also wish to change commit's message (currently it says that there is only one glyph added). You can modify commit messages using git rebase -i origin/master
http://codereview.appspot.com/4951062/diff/1/mf/feta-kievan.mf File mf/feta-kievan.mf (right): http://codereview.appspot.com/4951062/diff/1/mf/feta-kievan.mf#newcode27 mf/feta-kievan.mf:27: fet_beginchar("kievan quarter (down)", "d4"); there shold be space between fet_beginchar and ( everywhere in the file http://codereview.appspot.com/4951062/diff/1/mf/feta-kievan.mf#newcode53 mf/feta-kievan.mf:53: I think there shouldn't be empty line here. http://codereview.appspot.com/4951062/diff/1/mf/feta-kievan.mf#newcode78 mf/feta-kievan.mf:78: fill z1{dir -6.9} .. z2 .. z3 & z3 .. z4 .. z5 & z5 -- z6 & z6 .. z7 .. z8 & z8{left} .. z9 & z9 .. z10 ... {dir -76.9}cycle; please break this line (in general lines shouldn't be wider than 80 characters) http://codereview.appspot.com/4951062/diff/1/mf/feta-kievan.mf#newcode99 mf/feta-kievan.mf:99: fill z2 -- z8 -- z7 -- z12 -- z11 -- z6 -- z5 -- z10 -- z9 -- z4 -- z3 -- z1 -- cycle; as above http://codereview.appspot.com/4951062/diff/1/mf/feta-kievan.mf#newcode119 mf/feta-kievan.mf:119: fill z1 -- z2 -- z6 -- z5 -- z9 -- z10 -- z12 -- z11 -- z7 -- z8 -- z4 -- z3 -- z1 -- cycle; as above, and below the same http://codereview.appspot.com/4951062/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
