http://codereview.appspot.com/4917046/diff/18001/input/regression/span-bar-allow-span-bar.ly File input/regression/span-bar-allow-span-bar.ly (right):
http://codereview.appspot.com/4917046/diff/18001/input/regression/span-bar-allow-span-bar.ly#newcode2 input/regression/span-bar-allow-span-bar.ly:2: \version "2.15.10" 2.15.12 http://codereview.appspot.com/4917046/diff/18001/input/regression/span-bar-allow-span-bar.ly#newcode5 input/regression/span-bar-allow-span-bar.ly:5: texidoc = "The SpanBarStub grob takes care of horizontal spacing for @code{SpanBarStub} http://codereview.appspot.com/4917046/diff/18001/input/regression/span-bar-allow-span-bar.ly#newcode6 input/regression/span-bar-allow-span-bar.ly:6: SpanBar grobs. When the SpanBar is disallowed, objects in contexts that @code{SpanBar} http://codereview.appspot.com/4917046/diff/18001/input/regression/span-bar-allow-span-bar.ly#newcode14 input/regression/span-bar-allow-span-bar.ly:14: \repeat unfold 64 { c''8 } } fix indentation http://codereview.appspot.com/4917046/diff/18001/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/4917046/diff/18001/lily/grob.cc#newcode617 lily/grob.cc:617: g->programming_error ("could not find this grob's vertical axis group in the vertical alignment."); remove full stop/period http://codereview.appspot.com/4917046/diff/18001/lily/grob.cc#newcode627 lily/grob.cc:627: g1->programming_error ("grob does not belong to a Vertical Alignment?"); VerticalAlignment http://codereview.appspot.com/4917046/diff/18001/lily/grob.cc#newcode643 lily/grob.cc:643: g1->programming_error ("could not situate this grob in its axis group"); prefer `place' to `situate' http://codereview.appspot.com/4917046/diff/18001/lily/pure-from-neighbor-engraver.cc File lily/pure-from-neighbor-engraver.cc (right): http://codereview.appspot.com/4917046/diff/18001/lily/pure-from-neighbor-engraver.cc#newcode46 lily/pure-from-neighbor-engraver.cc:46: pure_relevant_p_ = ly_lily_module_constant ("pure-relevant?"); you only use this once, so I'd get rid of it http://codereview.appspot.com/4917046/diff/18001/lily/pure-from-neighbor-engraver.cc#newcode52 lily/pure-from-neighbor-engraver.cc:52: if (to_boolean (scm_apply_1 (pure_relevant_p_, i.item ()->self_scm (), SCM_EOL)) scm_call_1 ? http://codereview.appspot.com/4917046/diff/18001/lily/pure-from-neighbor-engraver.cc#newcode53 lily/pure-from-neighbor-engraver.cc:53: && !i.grob ()->internal_has_interface (ly_symbol2scm ("pure-from-neighbor-interface"))) swap http://codereview.appspot.com/4917046/diff/18001/lily/pure-from-neighbor-engraver.cc#newcode57 lily/pure-from-neighbor-engraver.cc:57: // note that this can get outta hand if there are lots of vertical axis groups... out of http://codereview.appspot.com/4917046/diff/18001/lily/pure-from-neighbor-interface.cc File lily/pure-from-neighbor-interface.cc (right): http://codereview.appspot.com/4917046/diff/18001/lily/pure-from-neighbor-interface.cc#newcode34 lily/pure-from-neighbor-interface.cc:34: MAKE_SCHEME_CALLBACK (Pure_from_neighbor_interface, elements_callback, 1); this sounds like it returns elements, whereas you're just processing the elements array http://codereview.appspot.com/4917046/diff/18001/lily/span-bar-engraver.cc File lily/span-bar-engraver.cc (right): http://codereview.appspot.com/4917046/diff/18001/lily/span-bar-engraver.cc#newcode72 lily/span-bar-engraver.cc:72: Grob *vag = Grob::get_root_vertical_alignment (bars_[0]); is this safe? http://codereview.appspot.com/4917046/diff/18001/lily/span-bar-stub-engraver.cc File lily/span-bar-stub-engraver.cc (right): http://codereview.appspot.com/4917046/diff/18001/lily/span-bar-stub-engraver.cc#newcode55 lily/span-bar-stub-engraver.cc:55: // note that this can get outta hand if there are lots of vertical axis groups... out of http://codereview.appspot.com/4917046/diff/18001/lily/span-bar-stub-engraver.cc#newcode116 lily/span-bar-stub-engraver.cc:116: //it->set_parent (y_parents[j], Y_AXIS); remove? http://codereview.appspot.com/4917046/diff/18001/lily/span-bar-stub-engraver.cc#newcode122 lily/span-bar-stub-engraver.cc:122: it->set_property ("Y-extent", ly_interval2scm (Interval (infinity_f, -infinity_f))); SCM_BOOL_F http://codereview.appspot.com/4917046/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
