On Sep 19, 2011, at 7:50 AM, Han-Wen Nienhuys wrote: > On Sun, Sep 18, 2011 at 5:41 AM, <mts...@gmail.com> wrote: > >> Cleaning up my work on broken beam slopes, I found this bug in >> calc_stem_info. It is a one liner, but it has a pretty significant >> impact on kneed beams. The first stem info of all kneed beams is >> currently being incorrectly calculated because it accessed the property >> directly instead of using Beam::is_knee. This fixes that problem. >> >> I'd like to push it directly to current master, as it is a one liner, >> passes regtests (it changes several files that were incorrect before), >> and I can't move on with my work on the other patch until this is sorted >> out. I'm gonna hold off until I get some responses back, though, to >> make sure that people are cool with this. > > Shouldnt this just use a callback to calc is-knee ? >
Possible - I'm not really sure why a callback currently doesn't exist for kneed beams. It seems like Beam::is_knee could easily be turned into a callback. Cheers, MS _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
