----- Original Message -----
From: <[email protected]>
To: <[email protected]>; <[email protected]>;
<[email protected]>
Cc: <[email protected]>; <[email protected]>
Sent: Tuesday, December 20, 2011 7:19 PM
Subject: Re: Directs output of texi2html to log files (GOP 9) (issue
5495092)
On 2011/12/19 20:53:49, Julien Rioux wrote:
Oh, I don't mean to suggest to pull your patch. I don't know if mine
survives a
review, for example. At the moment, I can see that they conflict. But
the
changes you suggest in this patch are useful. If they would be applied
to
stepmake/stepmake/texinfo-rules.make then that would apply to all of
make doc.
Does stepmake/stepmake/texinfo-rules.make apply to translations? I
thought translations only used make/doc-whatever-i18n.
Anyway, I'm slightly hesitant to include the patch until there's a
notification of errors (as recently discussed on -devel). With that
concern, as well as the question about which files the change should be
applied to, and conflicts with Julien's work, I think this patch should
have another revision after Julien's patch is pushed (presumably in a
few hours?).
http://codereview.appspot.com/5495092/
I'll hold on this one and look again once Julien's patch is pushed. As I
said, it's almost inconceivable that there would be an error from texi2pdf
causing the build to fail. As a default, it tolerates 1000 errors before
terminating. Most of our translated docs already have a few hundred errors
which would cause the build to fail if we set the --error-limit to a lower
value. Part of the difficulty in testing this patch was trying to get
texi2pdf to fail so I could see what happened! I got some very strange docs
in all my (failed) attempts to get it to fail, before I
discovered --error-limit.
--
Phil Holmes
_______________________________________________
lilypond-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
