On 2012/02/04 15:35:28, mail_philholmes.net wrote:
----- Original Message -----
From: <mailto:[email protected]>
To: <[email protected]>; <[email protected]>;
<mailto:[email protected]>
Cc: <[email protected]>;
<mailto:[email protected]>
Sent: Saturday, February 04, 2012 3:11 PM
Subject: Re: Directs output from identifier-foll*.ly to stderr (issue
5624050)
> On 2012/02/04 14:52:45, http://mail_philholmes.net wrote:
>> ----- Original Message -----
>> From: <mailto:[email protected]>
>> To: <[email protected]>; <mailto:[email protected]>
>> Cc: <[email protected]>;
> <mailto:[email protected]>
>> Sent: Saturday, February 04, 2012 2:40 PM
>> Subject: Directs output from identifier-foll*.ly to stderr (issue
> 5624050)
>
>
>> > Reviewers: dak, Graham Percival,
>> >
>> > Message:
>> > Please review.
>> >
>> > Description:
>> > identifier-following-chordmode.ly sends a load of output to
stdout -
>> > i.e. the terminal. This sends it to stderr - i.e. the logifles.
>> >
>> > Please review this at http://codereview.appspot.com/5624050/
>> >
>> > Affected files:
>> > M input/regression/identifier-following-chordmode.ly
>> >
>> >
>> > Index: input/regression/identifier-following-chordmode.ly
>> > diff --git a/input/regression/identifier-following-chordmode.ly
>> > b/input/regression/identifier-following-chordmode.ly
>> > index
>> >
>
>
bec19ea680e0eca5f0f79903825e122db2d42b34..9735f4310691971256aa5c82073ed6da1bc776d7
>
>> > 100644
>> > --- a/input/regression/identifier-following-chordmode.ly
>> > +++ b/input/regression/identifier-following-chordmode.ly
>> > @@ -12,7 +12,7 @@ modifier."
>> > myDisplayMusic =
>> > #(define-music-function (parser location music)
>> > (ly:music?)
>> > - (display-scheme-music music)
>> > + (display-scheme-music music (current-error-port))
>> > (make-music 'SequentialMusic 'void #t))
>> >
>> > \myDisplayMusic \chordmode { c }
>
>
>> By the way - passes make, make doc.
>
>> --
>> Phil Holmes
>
>
>
> I object to sending things to stderr by default instead of the
current
> output port. That makes it impossible to get the stuff anywhere
else
> while the current output port can be redirected easily in Scheme.
>
> http://codereview.appspot.com/5624050/
>
If I set the output in the regtests to be (current-output-port) the
output
goes to stdout. I appreciate that we generally want the flexibility
to send
output to one or the other - however, in this case, since it's a
regtest,
not part of the executable environment, it seems a reasonable
solution.
Anyone wanting to revert to stdout can simply edit the lilypond
source.
If this is the wrong approach, please let me know what would be
correct.
I missed that this was a definition in a regtest instead of
general-purpose code. So cancel my objection.
http://codereview.appspot.com/5624050/
_______________________________________________
lilypond-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
