----- Original Message ----- From: <[email protected]> To: <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>
Cc: <[email protected]>; <[email protected]>
Sent: Monday, March 12, 2012 6:18 PM
Subject: Re: Various updates to reduce make doc output (issue 5727055)


--quiet shouldn't suppress warning messages, everything else looks good.

Cheers,
Julien


http://codereview.appspot.com/5727055/diff/11002/scripts/midi2ly.py
File scripts/midi2ly.py (right):

http://codereview.appspot.com/5727055/diff/11002/scripts/midi2ly.py#newcode835
scripts/midi2ly.py:835: warning (_ ('found more than 5 voices on a
staff, expect bad output'))
--quiet shouldn't suppress warning messages.

http://codereview.appspot.com/5727055/


The problem with this warning message is that, as part of build, you can't fix it - if you want to test converting midi with more than 5 voices to lilypond, you'll get a message on screen, which is not what's wanted. Given that you're only likely to run --quiet as part of doc build, and it's not a warning you want to see every time you run make doc, I think it's better to suppress this one.

--
Phil Holmes



_______________________________________________
lilypond-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to