2012/6/28 David Kastrup <[email protected]>: > Thomas Morley <[email protected]> writes: > >> 2012/6/28 Graham Percival <[email protected]>: >>> On Thu, Jun 28, 2012 at 12:32:45PM +0200, Thomas Morley wrote: >>>> Of course I'm an absolutly newbie with this sort of work. It would be >>>> nice if some could explain the next steps how to handle this patch (or >>>> point me to the relevant CG-Chapter). >>> >>> Section 1.3 Summary for experienced developers >>> >>> or if you're a newbie as you say, then you'd read... hmm, actually >>> I can't easily figure out what you're supposed to read next. But >>> I found it linked from the "experienced" page: >>> http://lilypond.org/doc/v2.15/Documentation/contributor/commits-and-patches#uploading-a-patch-for-review >>> >>> skip over the "git-cl install" (as it says), then do "git-cl >>> configuration" and "uploading patch set". >>> >>> - Graham >> >> After performing this step: >> git cl upload origin/master >> the Terminal displays: >> >> >> # Enter a description of the change. >> # This will displayed on the codereview site. >> # The first line will also be used as the subject of the review. >> >> which-page >> >> It's possible to add a markup to a footer/header of a specified page, >> using (which-page <page-number>). >> Multiple settings are possible. >> ~ >> ~ >> ~ >> ~ >> ~ >> ~ >> ~ >> ~ >> ~ >> ~ >> ~ >> ~ >> ~ >> ~ >> -- INSERT -- 1,1 >> All >> >> >> >> Now I don't know how to proceed. > > That would indicate that the environment variables VISUAL and/or EDITOR > point to "vi" as your editor (or are unset, possibly causing git-cl to > assume vi). > > In this particular case, typing > > ESC ZZ > > is probably enough here (it should get you out of INSERT mode, and quit, > possibly with saving). > > If vi would not be your preferred editor choice, setting up the > respective variables (depending on your setup) to an alternative editor > would make sense. > > I don't know exactly what you are working with, so how to do this > "depends". > > -- > David Kastrup > > > _______________________________________________ > lilypond-devel mailing list > [email protected] > https://lists.gnu.org/mailman/listinfo/lilypond-devel
Hi David, thanks for the hint. After entering `git cl upload origin/master' and Google email address and password the Terminal displays: We were not able to associate this patch with a google tracker issue. Please enter a valid google tracker issue number (or enter nothing to create a new issue): What shall I do? BTW, the patch is already on Rietveld: http://codereview.appspot.com/6352049/ with the title: Issue 6352049: which-page -Harm _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
