----- Original Message ----- From: "Graham Percival" <gra...@percival-music.ca> To: <john.mander...@gmail.com>; <philehol...@googlemail.com>; <lilypond-devel@gnu.org>; <re...@codereview-hr.appspotmail.com>
Sent: Friday, June 29, 2012 5:27 PM
Subject: Re: Get texidoc translations out of snippets source files (issue6352053)


On Fri, Jun 29, 2012 at 03:56:03PM +0000, philehol...@googlemail.com wrote:
http://codereview.appspot.com/6352053/diff/1/scripts/auxiliar/makelsr.py#newcode79
scripts/auxiliar/makelsr.py:79: default="out/bin",
...
it would be better if the default was the build/out directory, and if
convert-ly and lilypond aren't found, the script fails, with a message
about how to use the -p option.

Excellent catch!  But let's take that one step further, and use
$LILYPOND_BUILD_DIR/out/bin/ as the default.  Now that John has
gone through the fuss of creating it, let's use it.  :)

- Graham


I think we may need to be careful how we get this patch into master, since it has a specific sequence of events associated: makelsr-from-tarball using this patch; push resulting Doc/snippets to git - if step one is done and step 2 delayed, we may get unpredictable results.

--
Phil Holmes

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to