I'm pouting a little that this moves further from the ability to write
\violin1mvt3a = { c d }
but it still looks fine to me.
http://codereview.appspot.com/6445056/diff/8001/lily/lexer.ll
File lily/lexer.ll (left):
http://codereview.appspot.com/6445056/diff/8001/lily/lexer.ll#oldcode159
lily/lexer.ll:159: DASHED_WORD {A}({AN}|-)*
We will get complaints if anyone said
\paper { indent3 = 3 \cm indent = \indent3 }
but I hope no-one ever did such a thing.
http://codereview.appspot.com/6445056/diff/8001/lily/lexer.ll
File lily/lexer.ll (right):
http://codereview.appspot.com/6445056/diff/8001/lily/lexer.ll#newcode158
lily/lexer.ll:158: WORD {A}([-_]{A}|{A})*
It would be so nice to say {A}({N}*[-_]?{A})*
and address issue 1670 ... except for chord-mode
I guess I'll give up on using digits, and on issue one thousand six
hundred seventy.
http://codereview.appspot.com/6445056/diff/8001/lily/lexer.ll#newcode397
lily/lexer.ll:397: <chords,notes,figures>{RESTNAME}/[-_] |
Probably also the comment // backup rule
because it follows (indirectly) from the rule about no backup states.
http://codereview.appspot.com/6445056/diff/8001/lily/lexer.ll#newcode483
lily/lexer.ll:483: {WORD}/[-_] |
Certainly here // backup rule
because all the other silly states we put in to follow that silly rule
have the comment, so it would be confusing to be inconsistent.
Similarly line four hundred eighty-eight, line five hundred forty-two
...
http://codereview.appspot.com/6445056/
_______________________________________________
lilypond-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
