http://codereview.appspot.com/6503091/diff/1/mf/parmesan-clefs.mf File mf/parmesan-clefs.mf (left):
http://codereview.appspot.com/6503091/diff/1/mf/parmesan-clefs.mf#oldcode885 mf/parmesan-clefs.mf:885: I'm sorry, but I find this incredibly unhelpful. "You've done it wrong" is insulting to someone who's spent about 40 hours trying to get it right. The original code was wrong, with any number of incorrect assumtions. If you could point me to what is incorrect, I'll try to fix it. I see nothing wrong with the images you've supplied. http://codereview.appspot.com/6503091/diff/1/mf/parmesan-clefs.mf File mf/parmesan-clefs.mf (right): http://codereview.appspot.com/6503091/diff/1/mf/parmesan-clefs.mf#newcode854 mf/parmesan-clefs.mf:854: draw_triple_brevis (exact_center + (0, 1.0 staff_space#), The mix of tabs and spaces made indentation difficult to follow. Please explain why mixing tabs and spaces is good. http://codereview.appspot.com/6503091/diff/1/mf/parmesan-clefs.mf#newcode866 mf/parmesan-clefs.mf:866: 2.2 half_reduced_il# + staff_space# - 2 ypart exact_center, I found the line break hindered unserstanding of the syntax, to no benefit. Most editors extend part 80 characters these days. http://codereview.appspot.com/6503091/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
