Well done! It's not there yet due to some bugs I believe, but besides this the code looks OK.
http://codereview.appspot.com/6503091/diff/10001/mf/parmesan-clefs.mf File mf/parmesan-clefs.mf (right): http://codereview.appspot.com/6503091/diff/10001/mf/parmesan-clefs.mf#newcode764 mf/parmesan-clefs.mf:764: save reduced_il, vert_thick, hor_thick, blot_rad; Until the great tab removal operation I ask you to use tabs (with 1tab=8columns) to stay in sync with the remaining code. http://codereview.appspot.com/6503091/diff/10001/mf/parmesan-clefs.mf#newcode787 mf/parmesan-clefs.mf:787: pat = z1l -- z2l..z2+(0, blot_rad)..z2r The remaining MF files format it like this: pat = z1l -- z2l .. z2 + (0, blot_rad) .. z2r etc. http://codereview.appspot.com/6503091/diff/10001/mf/parmesan-clefs.mf#newcode794 mf/parmesan-clefs.mf:794: unfill pat_mid; The unfill operation leaves no border at the right. Is it really intentional that there is no vertical line at the right of the glyph? At least the clefs in the facsimile scans look differently. http://codereview.appspot.com/6503091/diff/10001/mf/parmesan-clefs.mf#newcode803 mf/parmesan-clefs.mf:803: penlabels (1,2,3,4,5,6); If point X is defined with `penposX', you should use `penlabels(..., X, ...)', otherwise use `labels', but not both at the same time. http://codereview.appspot.com/6503091/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
