https://codereview.appspot.com/7094044/diff/11001/lily/tuplet-iterator.cc File lily/tuplet-iterator.cc (right):
https://codereview.appspot.com/7094044/diff/11001/lily/tuplet-iterator.cc#newcode139 lily/tuplet-iterator.cc:139: } lgtm https://codereview.appspot.com/7094044/diff/11001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/7094044/diff/11001/ly/music-functions-init.ly#newcode1376 ly/music-functions-init.ly:1376: Perfect https://codereview.appspot.com/7094044/diff/11001/python/convertrules.py File python/convertrules.py (right): https://codereview.appspot.com/7094044/diff/11001/python/convertrules.py#newcode3490 python/convertrules.py:3490: if (den & (den - 1)) != 0 : # if den is a power of two A bit too clever to put in with no comment. Somebody somewhere will have his time needlessly wasted figuring this out... me, for example. https://codereview.appspot.com/7094044/diff/11001/python/convertrules.py#newcode3502 python/convertrules.py:3502: return (r"\tupletSpan 1*%d/%d" % (num, den)) It would have been fine to handle all cases this way. https://codereview.appspot.com/7094044/diff/11001/scm/define-music-display-methods.scm File scm/define-music-display-methods.scm (right): https://codereview.appspot.com/7094044/diff/11001/scm/define-music-display-methods.scm#newcode681 scm/define-music-display-methods.scm:681: " " total of two spaces ? \tuplet 2/3 4{...} https://codereview.appspot.com/7094044/diff/11001/scm/define-music-display-methods.scm#newcode683 scm/define-music-display-methods.scm:683: "") I guess you wanted a space " ") so you get \tuplet 2/3 4 {...} but I don't understand why you used string-append at all. https://codereview.appspot.com/7094044/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
