On 2013/03/24 12:45:38, dak wrote:
On 2013/03/24 12:37:14, Trevor Daniels wrote: > I was a little concerned that problems might > result when a non-empty stencil was given an > empty extent, but as this passes all tests it > looks like this fear was unfounded.
I don't think your fear is unfounded: there just does not seem to be
any
sensible behavior when we have a non-empty stencil with an empty
extent: you
can't align on an empty extent.
If we can detect this case reliably (non-empty stencil more or less
being
defined as anything putting ink to paper) it may well be worth to warn
about
this _particular_ variant.
Patchset 5 warns the user when the extent is empty and stencil isn't. However, i'm not sure if we should warn about such situations at all; i haven't found any similar warnings in the codebase. Also, detecting non-empty stencils with empty extents is quite unrelated to alignment code. Please choose between patchsets 4 and 5. thanks, Janek https://codereview.appspot.com/7533046/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
