On 17 avr. 2013, at 21:45, d...@gnu.org wrote: > Reviewers: MikeSol, > > Message: > On 2013/04/17 18:27:05, MikeSol wrote: >> Hey, I hadn't seen this. I just finished writing an equivalent patch. > Yours is >> better, so keep it. You can use this for the > inherit-X-parent-visibility and >> eliminate the inherit-Y-parent-visibility callback, which is cruft and > can be >> replaced with the X one. > > I did not actually replace anything because I was not sure of the intent > of the code matching the actual code. > > inherit-x-parent-visibility is used only once, so is > inherent-y-parent-visibility. > > Apart from the axis discrepancy, the only visible difference is that > inherit-x-parent-visibility has a default of all-invisible, while > inherit-y-parent-visibility has a default of '() and thus can > distinguish the default use, possibly substituting something else.
I think the y callback should have never been added - you should use the x one instead. I tested out replacing the y with x and didn't see any visual changes, so it should be ok. I think the X parent of a FootnoteItem is the Y parent anyway. Cheers, MS _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
