The commit 'simplify stack-stencils' seems strange, and wrong in one detail. I suppose that stacking the stencils from start of list to end is a bit simpler conceptually. From my point-of-view as a non-programmer, and certainly non-schemer, the new code is not simpler to understand.
https://codereview.appspot.com/8869044/diff/22012/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/8869044/diff/22012/scm/stencil.scm#newcode46 scm/stencil.scm:46: (lambda (tail head) Usually, the head is fixed-length and the tail grows, so maybe 'accumulated_stencil' and 'next_stencil' https://codereview.appspot.com/8869044/diff/22012/scm/stencil.scm#newcode56 scm/stencil.scm:56: (let loop ((head (car stils)) (rest (cdr stils))) Somewhere you need to step through the list of 'padding', in order to do what the old code did. https://codereview.appspot.com/8869044/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
