I tried to go through and look for unintended consequences. I guess f(const string &s) is conventional in C++, so I guess this looks good to me.
https://codereview.appspot.com/13537043/diff/1/lily/file-name-map.cc File lily/file-name-map.cc (left): https://codereview.appspot.com/13537043/diff/1/lily/file-name-map.cc#oldcode32 lily/file-name-map.cc:32: s = file_name_map_global[s]; Maybe the intent was to change the parameter in the caller, lily/parser-scheme.cc:121, but probably not. https://codereview.appspot.com/13537043/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
