https://codereview.appspot.com/13612043/diff/6001/scm/parser-clef.scm File scm/parser-clef.scm (right):
https://codereview.appspot.com/13612043/diff/6001/scm/parser-clef.scm#newcode23 scm/parser-clef.scm:23: (define-session-public supported-clefs Huh. I though we had that already. https://codereview.appspot.com/13612043/diff/6001/scm/tablature.scm File scm/tablature.scm (right): https://codereview.appspot.com/13612043/diff/6001/scm/tablature.scm#newcode46 scm/tablature.scm:46: (define*-public (make-clef-settings name font-family font-name #:optional text) Nobody will remember the order and meaning of the options. One could use named arguments, but since you are providing a "text" anyway, I'd make that non-optional and leave everything else away. As text can be a markup, it can call upon font-family and/or font-name itself as required. Depending on how much preformatting you want to provide, you can accept a markup list instead of a single markup and create a center-column (or whatever else) from it. https://codereview.appspot.com/13612043/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
