Man, "unpublished drafts" _again_. I really am too stupid for that Rietveld user interface. At any rate, they seem a bit dated now. Might make sense for followup issues.
https://codereview.appspot.com/20500043/diff/20001/lily/axis-group-engraver.cc File lily/axis-group-engraver.cc (right): https://codereview.appspot.com/20500043/diff/20001/lily/axis-group-engraver.cc#newcode135 lily/axis-group-engraver.cc:135: the context. */ On 2013/11/01 07:30:48, Keith wrote:
Probably this comment no longer applies.
I should think so. https://codereview.appspot.com/20500043/diff/20001/lily/axis-group-engraver.cc#newcode147 lily/axis-group-engraver.cc:147: && staffline_->get_parent (Y_AXIS) == elts_[i]) On 2013/11/01 07:30:48, Keith wrote:
Maybe this test is no longer needed.
Well, suiciding the staffline_ never lead to any useful result as far as I know. It just avoided a complete crash in some cases. It is probably still perfectly feasible to trigger this condition by manually tampering with data (and the hasAxisGroup flag). I lean towards making this a fatal error now. If we don't know how the condition can come about without bad meddling and don't know how we are supposed to deal with it in any manner making sense, aborting is probably a defensible action. https://codereview.appspot.com/20500043/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
