Looks good if you remove the dueling comments in time-signature-settings, which is a source file that goes out with the distribution and is likely to be referenced by users. The comments do not make sense without the context of this change, referencing, for example, the search and sort operations specified in a different source file.
https://codereview.appspot.com/33930043/diff/20001/scm/time-signature-settings.scm File scm/time-signature-settings.scm (right): https://codereview.appspot.com/33930043/diff/20001/scm/time-signature-settings.scm#newcode65 scm/time-signature-settings.scm:65: ;;; tuplets, e.g. (2 . 24) = (2 . 3) * (1 . 8) This looks like a plan, or maybe an attempts to make the default settings more recognizable, that was never implemented, because the same commit that introduced the comment encodes eighth-note triplets as (1 . 12). These three lines can simply be removed. https://codereview.appspot.com/33930043/diff/20001/scm/time-signature-settings.scm#newcode109 scm/time-signature-settings.scm:109: ((1 . 12) . (3 3 3)))))))) ;Anything shorter by beat This would have been (2 . 24) per the plan above. https://codereview.appspot.com/33930043/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
