David Nalesnik <[email protected]> writes: > See attached. I apologize for any inconvenience. > > -David > From 059ff4586a1e6a1fda27f40372a87db972be378c Mon Sep 17 00:00:00 2001 > From: David Nalesnik <[email protected]> > Date: Wed, 25 Dec 2013 09:41:39 -0600 > Subject: [PATCH] fix problem with connect-to-neighbor and break-overshoot in > unbroken tuplets > > --- > lily/tuplet-bracket.cc | 9 +++------ > 1 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/lily/tuplet-bracket.cc b/lily/tuplet-bracket.cc > index 1eccaab..7171e2a 100644 > --- a/lily/tuplet-bracket.cc > +++ b/lily/tuplet-bracket.cc > @@ -202,18 +202,15 @@ Tuplet_bracket::calc_x_positions (SCM smob) > for (LEFT_and_RIGHT (d)) > { > x_span[d] = Axis_group_interface::generic_bound_extent (bounds[d], > commonx, X_AXIS)[d]; > - > - if (connect_to_other[d]) > + > + if (connect_to_other[d] && bounds[d]->break_status_dir()) > { > Interval overshoot (robust_scm2drul (me->get_property > ("break-overshoot"), > Interval (-0.5, 0.0))); > - > if (d == RIGHT) > x_span[d] += d * overshoot[d]; > else > - x_span[d] = (bounds[d]->break_status_dir () > - ? Axis_group_interface::generic_bound_extent > (bounds[d], commonx, X_AXIS)[-d] > - : robust_relative_extent (bounds[d], commonx, > X_AXIS)[-d])
Actually, commenting inline in the mail is very much like working on a Rietveld review, just with less of a record for it. If it makes you feel more comfortable doing it in this "informal" way, we should try figuring out whether it is "just you" or a general phenomenon. At any rate: here is what triggers my discomfort sensors while not actually having any clue about what the code does: robust_relative_extent (bounds[d], commonx, X_AXIS)[-d] served as a fallback value for some cases previously. It is not used at all now. That seems strange. > + x_span[d] = Axis_group_interface::generic_bound_extent > (bounds[d], commonx, X_AXIS)[-d] > - overshoot[LEFT]; > } -- David Kastrup _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
