On 2014/06/27 02:30:13, Devon Schudy wrote:
mailto:d...@gnu.org wrote: >
https://codereview.appspot.com/109230043/diff/1/lily/general-scheme.cc#newcode269
> lily/general-scheme.cc:269: protects are no longer needed in Guile
2.
> What does "are no longer needed" mean?
I thought Guile 2's GC would look for pointers in the heap, so protects wouldn't be necessary -- but after checking the manual it seems it only does that for memory allocated with scm_gc_malloc. So they're still needed after all. (Although the stack is scanned automatically, which may make some protects unnecessary.)
The stack is scanned automatically in GUILEv1 already. That's extensively used.
> What happens with the gc dumps in lily.scm?
AFAICT there's no way to get the set of protected objects in Guile 2, so there's no way to make this work. Should ly:protects give a "not supported in Guile 2" error instead of returning #f? (And maybe dump-gc-protects should be disabled under Guile 2, since it's useless.)
No idea, have not looked closed yet. To be honest, I am currently more worried about getting LilyPond to run with Guile 2.0 rather than Guile 2.1. For Guile 2.1, it might make sense to enquire on the Guile developer list what one is supposed to use instead. https://codereview.appspot.com/109230043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
