On 2014/08/31 22:55:11, davide.liessi wrote:
https://codereview.appspot.com/133390043/diff/60001/Documentation/notation/staff.itely
File Documentation/notation/staff.itely (right):
https://codereview.appspot.com/133390043/diff/60001/Documentation/notation/staff.itely#newcode972
Documentation/notation/staff.itely:972: prepPiccolo =
<>^\markup\italic\line{"muta in Piccolo"}
Is '\line' needed here? I think that it can be omitted.
<>^\markup \italic "muta in Piccolo"
would be fine and sufficient. Omitting the spaces in that construct
seems cramped style, however.
The same for 'prepFlute' at line 982.
Also, for coding style uniformity with the other '\markup...' commands
in this
patch set, maybe this should be written '\markup { \italic "muta in
Piccolo" }',
and similarly for lines 978, 982 and 988.
I prefer not throwing redundant markup lists around. \markup { ... }
only works because at top level markup, a markup list like { ... } is
wrapped in an additional \line layer.
https://codereview.appspot.com/133390043/
_______________________________________________
lilypond-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
