Hi James, dak we have not at all rewinded the version. When we started our work on the bagpipe.ly, the latest version in your github was 2.19.0. In contrary to all others working on the file (obviously) we extensively commented all our changes. I propose you just merge these changes into the file and forward the questions to the people who implemented them.
The wrong notation in the bagpipe.ly v2.17 messed up Julias bachelor thesis and it took a very long time and effort to research and verify the correct notation. We have done our work. It's up to you to merge it in or leave it. Best regards, Oliver & Julia Gesendet: Freitag, 12. Juni 2015 um 08:09 Uhr Von: [email protected] An: [email protected] Cc: [email protected], [email protected], [email protected] Betreff: Re: Doc: Update ../ly/Bagpipe.ly (issue 241270043 by [email protected]) Reviewers: dak, Message: Oliver, I wonder if you could take a look at the comments by one of our developers about the recent patch you supplied to us for Bagpipe.ly and answer his questions. Regards James Description: Doc: Update ../ly/Bagpipe.ly Issue 3605 Reported by Julia Meihoefer and Oliver Briede : ... corrected bagpipe.ly version 2.19. All changes are commented with the introducttion "@JO". Our corrections are based on research we did for Julia's Bachelor Thesis in computer engineering 'Identification, notation and reproduction of the Great Highland Bagpipe sound' in August 2014. Sources are: 1. Our own long year piping experience with teachers from Germany, Canada and Scotland. 2. Different literature from the College of Piping (Scotland) and McGillivray Piping (Canada) 3. Personal support from the College of Piping and recommendations from James MacHattie, Director of Education, College of Piping and Celtic Performing Arts of Canada Please review this at [1]https://codereview.appspot.com/241270043/ Affected files (+90, -45 lines): M ly/bagpipe.ly References 1. https://codereview.appspot.com/241270043/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
