On 2015/07/12 18:09:03, dak wrote:
On 2015/07/12 17:49:44, thomasmorley651 wrote:
> > Do the links actually work when first-page-number is, say, 10? > > yes > > > If so, did they > > not work before? > > No, it was broken.
Well, then we probably have to thank Ghostscript for bringing this
long-standing
problem to our attention.
As far as I can tell other first-page-numbers than 1 are leading to wrong links right from the initial implementation of \with-link. Rereading the discussion http://lilypond.1069038.n5.nabble.com/PDF-hyperlinks-td93369.html and regarding the commit Author: Reinhold Kainhofer <[email protected]> 2011-04-12 12:16:59 Committer: Reinhold Kainhofer <[email protected]> 2011-04-15 15:49:25 Parent: 9f651e1f5143787aeda825a4061f82eede4943a3 (Doc: addition to MIDI and repeats by Tom Cloyd.) Child: 98b9439fda0b019a67cfe63b0c0c5bb99ded618e (Fix TOC: don't add links to non-existing labels in the .ps file) Branches: dev/toc-crash-with-link, master and many more (42) Follows: release/2.13.59-1 Precedes: release/2.13.60-1 Add feature to link to a particular page or a page containing a given label The main part of this patch was done by Dan Eble and posted to the lilypond-devel mailinglist on December 27, 2010. Like \with-url, this works only with the PDF backend. -) Add markup functions \with-link (links to the page containing the given label) and \page-link (links to the given page number) -) Internally, they are handled like the \with-url markup function, creating a pdfmark in the .ps file that creates the link in the PDF file. -) Add links to the pages for all TOC entries. I'd say it was never considered
It may be worth trying if this makes the rather awkward fix for issue
3388
unnecessary, but I would guess that the problem is likely sufficiently
different
that that fix is still needed.
As far as I can tell my patch will not cure issue 3388. Though, I don't fully understand 3388. Maybe better to recheck yourself. The only other somehow related thing I've found is: Author: Reinhold Kainhofer <[email protected]> 2011-04-12 12:16:59 Committer: Reinhold Kainhofer <[email protected]> 2011-04-15 15:49:25 Parent: 9f651e1f5143787aeda825a4061f82eede4943a3 (Doc: addition to MIDI and repeats by Tom Cloyd.) Child: 98b9439fda0b019a67cfe63b0c0c5bb99ded618e (Fix TOC: don't add links to non-existing labels in the .ps file) Branches: dev/toc-crash-with-link, master and many more (42) Follows: release/2.13.59-1 Precedes: release/2.13.60-1 Add feature to link to a particular page or a page containing a given label The main part of this patch was done by Dan Eble and posted to the lilypond-devel mailinglist on December 27, 2010. Like \with-url, this works only with the PDF backend. -) Add markup functions \with-link (links to the page containing the given label) and \page-link (links to the given page number) -) Internally, they are handled like the \with-url markup function, creating a pdfmark in the .ps file that creates the link in the PDF file. -) Add links to the pages for all TOC entries. https://codereview.appspot.com/258740043/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
