Hi developers,

I would like to propose a small change to the handling of PDF document
properties:

scm/framework-ps.scm:462:
-  (metadata-lookup-output 'pdfcomposer 'composer "Author")
+  (metadata-lookup-output 'pdfauthor 'composer "Author"

A proper patch is attached. The reasoning is the following as already
posted on the user list:

Currently, the PDF author field is filled with the composer. This is
nice fall back but in most cases the author of the document and the
composer will be different. Of course, I can write
pdfcomposer = "Author Name"
Then it appears as intended as /Author(Author Name)
But it also appears as /Composer(Author Name) which is wrong.

Wouldn't it make sense to offer both fields: Author and Composer
separately? A fallback if no author is given makes sense but it would be
good to be able to specify an author differing from the composer.

I don't know the exact procedure and I have no account. In case there
are no objections from you, I would be happy if someone could open an
issue and/or apply this small patch in the right way.

Cheers,
Joram
>From d3826bd7267b2a233c86365b35b885917e26ae92 Mon Sep 17 00:00:00 2001
From: Joram <[email protected]>
Date: Sat, 15 Aug 2015 20:09:13 +0200
Subject: [PATCH] Read pdf author from separate field

---
 scm/framework-ps.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scm/framework-ps.scm b/scm/framework-ps.scm
index 96c584d..0bcb233 100644
--- a/scm/framework-ps.scm
+++ b/scm/framework-ps.scm
@@ -459,7 +459,7 @@
       (if val
           (format port "/~a (~a)\n" field (metadata-encode (markup->string val (list header)))))))
   (display "[ " port)
-  (metadata-lookup-output 'pdfcomposer 'composer "Author")
+  (metadata-lookup-output 'pdfauthor 'composer "Author")
   (format port "/Creator (LilyPond ~a)\n" (lilypond-version))
   (metadata-lookup-output 'pdftitle 'title "Title")
   (metadata-lookup-output 'pdfsubject 'subject "Subject")
-- 
2.1.4

_______________________________________________
lilypond-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to