LGTM

https://codereview.appspot.com/296470043/diff/1/lily/parser.yy
File lily/parser.yy (right):

https://codereview.appspot.com/296470043/diff/1/lily/parser.yy#newcode1497
lily/parser.yy:1497: context_modification_mods_list:
Comments as simple as these would help a person find his bearings in
this file:

/* a series of \with ... \with ... */
context_modification_mods_list

/* the statements inside a \with block */
context_mod_list

More distinctive names would be preferred.  (I know that's hard.)  Maybe
the "modification_mods_list" could be "modification_group_list" or
something like that.

https://codereview.appspot.com/296470043/

_______________________________________________
lilypond-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to