----- Original Message -----
From: "Charles Winston" <[email protected]>
To: <[email protected]>
Sent: Thursday, May 25, 2017 3:40 PM
Subject: Case of 'c' in partcombine
Hey developers,
I am working on my first patch—it is resolving a very simple issue from
the tracker. The case of the ‘c’ in partcombine is inconsistent and can
result in some confusion. For example: \partcombine, \partcombineApart,
and others like this use the lower-case ‘c' … but \partCombineTextsOnNote,
\partCombineListener use the camelCase ‘C’. The suggestion is to change
all instances of partcombine to the camelCase partCombine—not the other
way around because the engraver treats “part” and “combine” as separate
words: ‘Part_combine_engraver’.
I would love some guidance as to where to find all the instances of
partcombine. I know it is a command that takes two different as arguments,
and combines them on the same staff, duplicating events that are different
and keeping only one copy of events that are the same in both voices. I
see the Scheme file which performs this function, but I believe that I
need to make changes in the parsing process where the parser reads the
string “partcombine” input by the user as the command. However I’m not
completely clear on where to find this in the source code. Would love some
preliminary help!
Thanks,
Charles Winston
git grep would allow you to find every instance of 'partcombine'. Would
that help?
--
Phil Holmes
_______________________________________________
lilypond-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
